feat: implement profile settings feature #808

OgDev-01 · 2023-01-27T18:52:43Z

What type of PR is this? (check all applicable)

Description

This PR:

implements the user profile update settings screen
adds email regex check from SO https://stackoverflow.com/a/46181/13002614
adds settings and userprofile link to the top user auth dropdown
fix card horizontal bar chart to show language name on hover
Implements user email preference update functionality

Notes:

the profile update is limited to just email, interests and email preference for now
all text input fields are disabled except the email for now

Related Tickets & Documents

Fixes #794
Fixes #784
Fixes #785
Fixes #798
Fixes #810

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-01-27T18:52:56Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`f240786`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/63d977c698059b000872a90d
😎 Deploy Preview	https://deploy-preview-808--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-01-27T18:53:06Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`f240786`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/63d977c663b234000a2cda41
😎 Deploy Preview	https://deploy-preview-808--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie

A few copy changes. Also mentioned this a few times, but we need UTC in the timezone list.

Starts from UTC-12 and goes to UTC+14. UTC with no disjuncture should show in this list.

https://en.wikipedia.org/wiki/List_of_UTC_offsets

Missing data

We can use the user data displayed on the profile from ContributorProfileInfo as placeholders instead of the April O'Neal design copy. Assuming the user can only view this page if they are logged, we should be able to get that data.

For Twitter, we can add "coming soon" as placeholder.

components/organisms/UserSettingsPage/user-settings-page.tsx

getaheaddev · 2023-01-29T00:12:21Z

Instead of using the github profile photo use the SVG. It'll prevent it from be over used.

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

npm-shrinkwrap.json
package.json

bdougie

Remind me Sunday, is getting an error expected?

can add the 🚫 cursor on the disabled fields?
Updating my timezone is not working. Pictured below.
Can't click any checkbox?
Need to remove avatar and use the person svg

Also @brandonroberts are the elements like bio, url, and twitter username available in the api?

bdougie · 2023-01-30T18:10:51Z

Updating my timezone is not working. Pictured below.

brandonroberts · 2023-01-30T18:26:03Z

@bdougie yes those are available in the authenticated session and the public user profile data

bdougie · 2023-01-30T18:28:43Z

@bdougie yes those are available in the authenticated session and the public user profile data

Ok @OgDev-01 if these are available can we add these in the UI, or come up with a plan to update them shortly after. We got a slow start on this feature and I'd love to ship what is usable as soon as possible.

OgDev-01 · 2023-01-30T18:34:56Z

@bdougie yes those are available in the authenticated session and the public user profile data

Ok @OgDev-01 if these are available can we add these in the UI, or come up with a plan to update them shortly after. We got a slow start on this feature and I'd love to ship what is usable as soon as possible.

What is the URL field intended for?

brandonroberts · 2023-01-30T19:05:44Z

@OgDev-01 the url field could be their primary website or some other URL they have on their GitHub profile data

bdougie · 2023-01-30T19:09:28Z

@OgDev-01 the url field could be their primary website or some other URL they have on their GitHub profile data

Mine is currently https://b.dougie.dev

I'd also recommend we updated th placeholder copy to be ContributorInfo that is already display on the profile pages on your other PR.

…pen-sauced/insights into 794-implement-profile-settings

bdougie

Looks good. Thanks for keeping this on track.

0-vortex

Some stray console.logs and branch not updated to latest beta but LGTM otherwise! 👍

brandonroberts

Need to remove the cached auth/session hook, but LGTM

brandonroberts · 2023-01-31T18:33:23Z

@OgDev-01 the Update Profile button is disabled initially until you update the email field. It should be enabled by default if the email is valid.

brandonroberts

LGTM

brandonroberts · 2023-01-31T20:17:15Z

@OgDev-01 just needs the fix on the build failure and we're good to merge

## [1.25.0-beta.11](v1.25.0-beta.10...v1.25.0-beta.11) (2023-02-01) ### 🍕 Features * implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706))

github-actions · 2023-02-01T14:53:48Z

🎉 This PR is included in version 1.25.0-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.26.0-beta.1](v1.25.0...v1.26.0-beta.1) (2023-02-02) ### 🍕 Features * add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820) * add user location and bio details to profile page ([#797](#797)) ([a301874](a301874)) * implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706)) ### 🐛 Bug Fixes * connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0))

github-actions · 2023-02-02T13:40:45Z

🎉 This PR is included in version 1.26.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.26.0-beta.1](v1.25.0...v1.26.0-beta.1) (2023-02-02) ### 🍕 Features * add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820) * add user location and bio details to profile page ([#797](#797)) ([a301874](a301874)) * implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706)) ### 🐛 Bug Fixes * connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0)) ### 🤖 Build System * correct dep versioning ([42a1b0a](42a1b0a)) * update some dependencies ([f522f5e](f522f5e))

github-actions · 2023-02-02T17:57:03Z

🎉 This PR is included in version 1.26.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.26.0](v1.25.0...v1.26.0) (2023-02-02) ### 🍕 Features * add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820) * add user location and bio details to profile page ([#797](#797)) ([a301874](a301874)) * implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706)) ### 🐛 Bug Fixes * connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0)) ### 🤖 Build System * correct dep versioning ([42a1b0a](42a1b0a)) * update some dependencies ([f522f5e](f522f5e))

github-actions · 2023-02-02T18:34:04Z

🎉 This PR is included in version 1.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* origin/main: (37 commits) chore(minor): release 1.26.0 [skip ci] chore(minor): release 1.26.0-beta.1 on beta channel [skip ci] build: update some dependencies build: correct dep versioning chore(patch): release 1.25.0-beta.14 on beta channel [skip ci] fix: connect more user profile settings to the API (#826) chore(minor): release 1.25.0-beta.13 on beta channel [skip ci] feat: add profile badge to connected user profile (#824) chore(minor): release 1.25.0-beta.12 on beta channel [skip ci] feat: add user location and bio details to profile page (#797) chore(minor): release 1.25.0-beta.11 on beta channel [skip ci] feat: implement profile settings feature (#808) chore(minor): release 1.25.0 [skip ci] (#818) chore(minor): release 1.25.0 [skip ci] v1.25.0-beta.10 -> production (#815) chore(minor): release 1.25.0-beta.10 on beta channel [skip ci] feat: set insight repo limit based on role (#813) chore(patch): release 1.25.0-beta.9 on beta channel [skip ci] fix: use correct avatar URL for caching (#800) chore(minor): release 1.25.0-beta.8 on beta channel [skip ci] ...

## [1.25.0-beta.11](open-sauced/app@v1.25.0-beta.10...v1.25.0-beta.11) (2023-02-01) ### 🍕 Features * implement profile settings feature ([#808](open-sauced/app#808)) ([4a8d706](open-sauced/app@4a8d706))

## [1.26.0-beta.1](open-sauced/app@v1.25.0...v1.26.0-beta.1) (2023-02-02) ### 🍕 Features * add profile badge to connected user profile ([#824](open-sauced/app#824)) ([e3a1fcf](open-sauced/app@e3a1fcf)), closes [#821](open-sauced/app#821) [#820](open-sauced/app#820) * add user location and bio details to profile page ([#797](open-sauced/app#797)) ([a301874](open-sauced/app@a301874)) * implement profile settings feature ([#808](open-sauced/app#808)) ([4a8d706](open-sauced/app@4a8d706)) ### 🐛 Bug Fixes * connect more user profile settings to the API ([#826](open-sauced/app#826)) ([01b8bc0](open-sauced/app@01b8bc0)) ### 🤖 Build System * correct dep versioning ([42a1b0a](open-sauced/app@42a1b0a)) * update some dependencies ([f522f5e](open-sauced/app@f522f5e))

## [1.26.0](open-sauced/app@v1.25.0...v1.26.0) (2023-02-02) ### 🍕 Features * add profile badge to connected user profile ([#824](open-sauced/app#824)) ([e3a1fcf](open-sauced/app@e3a1fcf)), closes [#821](open-sauced/app#821) [#820](open-sauced/app#820) * add user location and bio details to profile page ([#797](open-sauced/app#797)) ([a301874](open-sauced/app@a301874)) * implement profile settings feature ([#808](open-sauced/app#808)) ([4a8d706](open-sauced/app@4a8d706)) ### 🐛 Bug Fixes * connect more user profile settings to the API ([#826](open-sauced/app#826)) ([01b8bc0](open-sauced/app@01b8bc0)) ### 🤖 Build System * correct dep versioning ([42a1b0a](open-sauced/app@42a1b0a)) * update some dependencies ([f522f5e](open-sauced/app@f522f5e))

OgDev-01 added 3 commits January 27, 2023 19:47

feat: add profile update api function

7ed8cad

refactor: minor updates

5649bde

feat: add settings na d profile route

d1f7b7b

OgDev-01 added 3 commits January 28, 2023 13:16

feat: add toast support and validation

69764d0

chore: minor api call fixes

991bc88

refactor: remove unwanted code

8f063a5

OgDev-01 marked this pull request as ready for review January 28, 2023 12:53

OgDev-01 requested review from brandonroberts and bdougie January 28, 2023 12:56

OgDev-01 added the needs review PRs that need review from core engineering team label Jan 28, 2023

bdougie requested changes Jan 28, 2023

View reviewed changes

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

components/organisms/UserSettingsPage/user-settings-page.tsx Outdated Show resolved Hide resolved

bdougie added requested changes and removed needs review PRs that need review from core engineering team labels Jan 28, 2023

OgDev-01 added 2 commits January 30, 2023 18:33

refactor: update default values

b9a22c2

refactor: add timezone array to select options

d96d29c

github-actions bot reviewed Jan 30, 2023

View reviewed changes

OgDev-01 requested a review from bdougie January 30, 2023 17:53

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Jan 30, 2023

bdougie requested changes Jan 30, 2023

View reviewed changes

refactor: add cursor indication for disabled input

8d08219

OgDev-01 added 2 commits January 31, 2023 18:43

feat: implement update user email preference

22b1492

Merge branch '794-implement-profile-settings' of https://github.com/o…

0bacf82

…pen-sauced/insights into 794-implement-profile-settings

OgDev-01 requested review from brandonroberts and bdougie January 31, 2023 17:46

refactor: cleanup anf fininshing touches

92a1a23

bdougie approved these changes Jan 31, 2023

View reviewed changes

0-vortex suggested changes Jan 31, 2023

View reviewed changes

brandonroberts approved these changes Jan 31, 2023

View reviewed changes

OgDev-01 added 2 commits January 31, 2023 20:53

chore: general refactor and cleanup

56c1607

chore: update api call response

92f13b2

brandonroberts approved these changes Jan 31, 2023

View reviewed changes

fix: build error

f240786

OgDev-01 merged commit 4a8d706 into beta Feb 1, 2023

OgDev-01 deleted the 794-implement-profile-settings branch February 1, 2023 14:49

github-actions bot added the released on @beta label Feb 1, 2023

github-actions bot added the released label Feb 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement profile settings feature #808

feat: implement profile settings feature #808

OgDev-01 commented Jan 27, 2023 •

edited

Loading

netlify bot commented Jan 27, 2023 •

edited

Loading

netlify bot commented Jan 27, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading

getaheaddev commented Jan 29, 2023

github-actions bot left a comment

bdougie left a comment •

edited

Loading

bdougie commented Jan 30, 2023

brandonroberts commented Jan 30, 2023

bdougie commented Jan 30, 2023

OgDev-01 commented Jan 30, 2023

brandonroberts commented Jan 30, 2023 •

edited

Loading

bdougie commented Jan 30, 2023

bdougie left a comment

0-vortex left a comment

brandonroberts left a comment

brandonroberts commented Jan 31, 2023

brandonroberts left a comment

brandonroberts commented Jan 31, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

feat: implement profile settings feature #808

feat: implement profile settings feature #808

Conversation

OgDev-01 commented Jan 27, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Jan 27, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Jan 27, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

Missing data

getaheaddev commented Jan 29, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

PR Compliance Checks

Watched Files

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

bdougie commented Jan 30, 2023

brandonroberts commented Jan 30, 2023

bdougie commented Jan 30, 2023

OgDev-01 commented Jan 30, 2023

brandonroberts commented Jan 30, 2023 • edited Loading

bdougie commented Jan 30, 2023

bdougie left a comment

Choose a reason for hiding this comment

0-vortex left a comment

Choose a reason for hiding this comment

brandonroberts left a comment

Choose a reason for hiding this comment

brandonroberts commented Jan 31, 2023

brandonroberts left a comment

Choose a reason for hiding this comment

brandonroberts commented Jan 31, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

github-actions bot commented Feb 2, 2023

OgDev-01 commented Jan 27, 2023 •

edited

Loading

netlify bot commented Jan 27, 2023 •

edited

Loading

netlify bot commented Jan 27, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading

bdougie left a comment •

edited

Loading

brandonroberts commented Jan 30, 2023 •

edited

Loading